refactor(app): move constants to specific modules

app/agent/rest/agent.js

@@ -1,8 +1,10 @@
 import angular from 'angular';
 
+import { API_ENDPOINT_ENDPOINTS } from '@/constants';
+
 angular.module('portainer.agent').factory('Agent', AgentFactory);
 
-function AgentFactory($resource, API_ENDPOINT_ENDPOINTS, EndpointProvider, StateManager) {
+function AgentFactory($resource, EndpointProvider, StateManager) {
   return $resource(
     `${API_ENDPOINT_ENDPOINTS}/:endpointId/docker/v:version/agents`,
     {

app/agent/rest/browse.js

@@ -1,10 +1,11 @@
 import angular from 'angular';
 
+import { API_ENDPOINT_ENDPOINTS } from '@/constants';
 import { browseGetResponse } from './response/browse';
 
 angular.module('portainer.agent').factory('Browse', BrowseFactory);
 
-function BrowseFactory($resource, API_ENDPOINT_ENDPOINTS, EndpointProvider, StateManager) {
+function BrowseFactory($resource, EndpointProvider, StateManager) {
   return $resource(
     `${API_ENDPOINT_ENDPOINTS}/:endpointId/docker/v:version/browse/:action`,
     {

app/agent/rest/host.js

@@ -1,8 +1,9 @@
 import angular from 'angular';
+import { API_ENDPOINT_ENDPOINTS } from '@/constants';
 
 angular.module('portainer.agent').factory('Host', HostFactory);
 
-function HostFactory($resource, API_ENDPOINT_ENDPOINTS, EndpointProvider, StateManager) {
+function HostFactory($resource, EndpointProvider, StateManager) {
   return $resource(
     `${API_ENDPOINT_ENDPOINTS}/:endpointId/docker/v:version/host/:action`,
     {

app/agent/rest/ping.js

@@ -1,8 +1,10 @@
 import angular from 'angular';
 
+import { API_ENDPOINT_ENDPOINTS } from '@/constants';
+
 angular.module('portainer.agent').factory('AgentPing', AgentPingFactory);
 
-function AgentPingFactory($resource, API_ENDPOINT_ENDPOINTS, EndpointProvider, $q) {
+function AgentPingFactory($resource, EndpointProvider, $q) {
   return $resource(
     `${API_ENDPOINT_ENDPOINTS}/:endpointId/docker/ping`,
     {

app/agent/rest/v1/agent.js

@@ -1,8 +1,10 @@
 import angular from 'angular';
 
+import { API_ENDPOINT_ENDPOINTS } from '@/constants';
+
 angular.module('portainer.agent').factory('AgentVersion1', AgentFactory);
 
-function AgentFactory($resource, API_ENDPOINT_ENDPOINTS, EndpointProvider) {
+function AgentFactory($resource, EndpointProvider) {
   return $resource(
     `${API_ENDPOINT_ENDPOINTS}/:endpointId/docker/agents`,
     {

app/agent/rest/v1/browse.js

@@ -1,10 +1,11 @@
 import angular from 'angular';
 
+import { API_ENDPOINT_ENDPOINTS } from '@/constants';
 import { browseGetResponse } from '../response/browse';
 
 angular.module('portainer.agent').factory('BrowseVersion1', BrowseFactory);
 
-function BrowseFactory($resource, API_ENDPOINT_ENDPOINTS, EndpointProvider) {
+function BrowseFactory($resource, EndpointProvider) {
   return $resource(
     `${API_ENDPOINT_ENDPOINTS}/:endpointId/docker/browse/:volumeID/:action`,
     {

app/agent/services/hostBrowserService.js

@@ -1,8 +1,10 @@
 import angular from 'angular';
 
+import { API_ENDPOINT_ENDPOINTS } from '@/constants';
+
 angular.module('portainer.agent').factory('HostBrowserService', HostBrowserServiceFactory);
 
-function HostBrowserServiceFactory(Browse, Upload, API_ENDPOINT_ENDPOINTS, EndpointProvider, StateManager) {
+function HostBrowserServiceFactory(Browse, Upload, EndpointProvider, StateManager) {
   return { ls, get, delete: deletePath, rename, upload };
 
   function ls(path) {

app/agent/services/volumeBrowserService.js

@@ -1,8 +1,10 @@
 import angular from 'angular';
 
+import { API_ENDPOINT_ENDPOINTS } from '@/constants';
+
 angular.module('portainer.agent').factory('VolumeBrowserService', VolumeBrowserServiceFactory);
 
-function VolumeBrowserServiceFactory(StateManager, Browse, BrowseVersion1, API_ENDPOINT_ENDPOINTS, EndpointProvider, Upload) {
+function VolumeBrowserServiceFactory(StateManager, Browse, BrowseVersion1, EndpointProvider, Upload) {
   return {
     ls,
     get,

app/constants.js

@@ -1,34 +1,8 @@
-angular
-  .module('portainer')
-  .constant('API_ENDPOINT_AUTH', 'api/auth')
-  .constant('API_ENDPOINT_DOCKERHUB', 'api/dockerhub')
-  .constant('API_ENDPOINT_CUSTOM_TEMPLATES', 'api/custom_templates')
-  .constant('API_ENDPOINT_EDGE_GROUPS', 'api/edge_groups')
-  .constant('API_ENDPOINT_EDGE_JOBS', 'api/edge_jobs')
-  .constant('API_ENDPOINT_EDGE_STACKS', 'api/edge_stacks')
-  .constant('API_ENDPOINT_EDGE_TEMPLATES', 'api/edge_templates')
-  .constant('API_ENDPOINT_ENDPOINTS', 'api/endpoints')
-  .constant('API_ENDPOINT_ENDPOINT_GROUPS', 'api/endpoint_groups')
-  .constant('API_ENDPOINT_MOTD', 'api/motd')
-  .constant('API_ENDPOINT_REGISTRIES', 'api/registries')
-  .constant('API_ENDPOINT_RESOURCE_CONTROLS', 'api/resource_controls')
-  .constant('API_ENDPOINT_SETTINGS', 'api/settings')
-  .constant('API_ENDPOINT_STACKS', 'api/stacks')
-  .constant('API_ENDPOINT_STATUS', 'api/status')
-  .constant('API_ENDPOINT_SUPPORT', 'api/support')
-  .constant('API_ENDPOINT_USERS', 'api/users')
-  .constant('API_ENDPOINT_TAGS', 'api/tags')
-  .constant('API_ENDPOINT_TEAMS', 'api/teams')
-  .constant('API_ENDPOINT_TEAM_MEMBERSHIPS', 'api/team_memberships')
-  .constant('API_ENDPOINT_TEMPLATES', 'api/templates')
-  .constant('API_ENDPOINT_WEBHOOKS', 'api/webhooks')
-  .constant('API_ENDPOINT_BACKUP', 'api/backup')
-  .constant('DEFAULT_TEMPLATES_URL', 'https://raw.githubusercontent.com/portainer/templates/master/templates.json')
-  .constant('PAGINATION_MAX_ITEMS', 10)
-  .constant('APPLICATION_CACHE_VALIDITY', 3600)
-  .constant('CONSOLE_COMMANDS_LABEL_PREFIX', 'io.portainer.commands.')
-  .constant('PREDEFINED_NETWORKS', ['host', 'bridge', 'none'])
-  .constant('KUBERNETES_DEFAULT_NAMESPACE', 'default')
-  .constant('KUBERNETES_SYSTEM_NAMESPACES', ['kube-system', 'kube-public', 'kube-node-lease', 'portainer']);
-
+export const API_ENDPOINT_EDGE_JOBS = 'api/edge_jobs';
+export const API_ENDPOINT_ENDPOINTS = 'api/endpoints';
+export const API_ENDPOINT_REGISTRIES = 'api/registries';
+export const API_ENDPOINT_WEBHOOKS = 'api/webhooks';
+export const PAGINATION_MAX_ITEMS = 10;
 export const PORTAINER_FADEOUT = 1500;
+
+angular.module('portainer').constant('API_ENDPOINT_ENDPOINTS', API_ENDPOINT_ENDPOINTS);

app/docker/views/containers/console/containerConsoleController.js

@@ -1,5 +1,7 @@
 import { Terminal } from 'xterm';
 
+const CONSOLE_COMMANDS_LABEL_PREFIX = 'io.portainer.commands.';
+
 angular.module('portainer.docker').controller('ContainerConsoleController', [
   '$scope',
   '$transition$',
@@ -11,20 +13,7 @@ angular.module('portainer.docker').controller('ContainerConsoleController', [
   'ExecService',
   'HttpRequestHelper',
   'LocalStorage',
-  'CONSOLE_COMMANDS_LABEL_PREFIX',
-  function (
-    $scope,
-    $transition$,
-    ContainerService,
-    ImageService,
-    EndpointProvider,
-    Notifications,
-    ContainerHelper,
-    ExecService,
-    HttpRequestHelper,
-    LocalStorage,
-    CONSOLE_COMMANDS_LABEL_PREFIX
-  ) {
+  function ($scope, $transition$, ContainerService, ImageService, EndpointProvider, Notifications, ContainerHelper, ExecService, HttpRequestHelper, LocalStorage) {
     var socket, term;
 
     let states = Object.freeze({

app/edge/rest/edge-groups.js

@@ -1,6 +1,8 @@
 import angular from 'angular';
 
-angular.module('portainer.edge').factory('EdgeGroups', function EdgeGroupsFactory($resource, API_ENDPOINT_EDGE_GROUPS) {
+const API_ENDPOINT_EDGE_GROUPS = 'api/edge_groups';
+
+angular.module('portainer.edge').factory('EdgeGroups', function EdgeGroupsFactory($resource) {
   return $resource(
     API_ENDPOINT_EDGE_GROUPS + '/:id/:action',
     {},

app/edge/rest/edge-job-results.js

@@ -1,6 +1,8 @@
+import { API_ENDPOINT_EDGE_JOBS } from '@/constants';
+
 angular.module('portainer.edge').factory('EdgeJobResults', EdgeJobResultsFactory);
 
-function EdgeJobResultsFactory($resource, API_ENDPOINT_EDGE_JOBS) {
+function EdgeJobResultsFactory($resource) {
   return $resource(
     API_ENDPOINT_EDGE_JOBS + '/:id/tasks/:taskId/:action',
     {},

app/edge/rest/edge-jobs.js

@@ -1,6 +1,8 @@
+import { API_ENDPOINT_EDGE_JOBS } from '@/constants';
+
 angular.module('portainer.edge').factory('EdgeJobs', EdgeJobsFactory);
 
-function EdgeJobsFactory($resource, API_ENDPOINT_EDGE_JOBS) {
+function EdgeJobsFactory($resource) {
   return $resource(
     API_ENDPOINT_EDGE_JOBS + '/:id/:action',
     {},

app/edge/rest/edge-stacks.js

@@ -1,6 +1,8 @@
+const API_ENDPOINT_EDGE_STACKS = 'api/edge_stacks';
+
 import angular from 'angular';
 
-angular.module('portainer.edge').factory('EdgeStacks', function EdgeStacksFactory($resource, API_ENDPOINT_EDGE_STACKS) {
+angular.module('portainer.edge').factory('EdgeStacks', function EdgeStacksFactory($resource) {
   return $resource(
     API_ENDPOINT_EDGE_STACKS + '/:id/:action',
     {},

app/edge/rest/edge-templates.js

@@ -1,6 +1,8 @@
 import angular from 'angular';
 
-angular.module('portainer.edge').factory('EdgeTemplates', function EdgeStacksFactory($resource, API_ENDPOINT_EDGE_TEMPLATES) {
+const API_ENDPOINT_EDGE_TEMPLATES = 'api/edge_templates';
+
+angular.module('portainer.edge').factory('EdgeTemplates', function EdgeStacksFactory($resource) {
   return $resource(
     API_ENDPOINT_EDGE_TEMPLATES,
     {},

app/kubernetes/helpers/namespaceHelper.js

@@ -1,19 +1,16 @@
 import _ from 'lodash-es';
 import angular from 'angular';
 
-class KubernetesNamespaceHelper {
-  /* @ngInject */
-  constructor(KUBERNETES_SYSTEM_NAMESPACES, KUBERNETES_DEFAULT_NAMESPACE) {
-    this.KUBERNETES_SYSTEM_NAMESPACES = KUBERNETES_SYSTEM_NAMESPACES;
-    this.KUBERNETES_DEFAULT_NAMESPACE = KUBERNETES_DEFAULT_NAMESPACE;
-  }
+const KUBERNETES_SYSTEM_NAMESPACES = ['kube-system', 'kube-public', 'kube-node-lease', 'portainer'];
+const KUBERNETES_DEFAULT_NAMESPACE = 'default';
 
+class KubernetesNamespaceHelper {
   isSystemNamespace(namespace) {
-    return _.includes(this.KUBERNETES_SYSTEM_NAMESPACES, namespace);
+    return _.includes(KUBERNETES_SYSTEM_NAMESPACES, namespace);
   }
 
   isDefaultNamespace(namespace) {
-    return namespace === this.KUBERNETES_DEFAULT_NAMESPACE;
+    return namespace === KUBERNETES_DEFAULT_NAMESPACE;
   }
 }
 

app/portainer/components/datatables/genericDatatableController.js

@@ -1,5 +1,9 @@
+import angular from 'angular';
 import _ from 'lodash-es';
+
 import './datatable.css';
+
+import { PAGINATION_MAX_ITEMS } from '@/constants';
 import { ResourceControlOwnership as RCO } from 'Portainer/models/resourceControl/resourceControlOwnership';
 
 function isBetween(value, a, b) {
@@ -11,8 +15,8 @@ angular.module('portainer.app').controller('GenericDatatableController', [
   '$interval',
   'PaginationService',
   'DatatableService',
-  'PAGINATION_MAX_ITEMS',
-  function ($interval, PaginationService, DatatableService, PAGINATION_MAX_ITEMS) {
+
+  function ($interval, PaginationService, DatatableService) {
     this.RCO = RCO;
 
     this.state = {

app/portainer/helpers/networkHelper.js

@@ -1,14 +1,11 @@
 import _ from 'lodash-es';
 import angular from 'angular';
 
-class NetworkHelper {
-  /* @ngInject */
-  constructor(PREDEFINED_NETWORKS) {
-    this.PREDEFINED_NETWORKS = PREDEFINED_NETWORKS;
-  }
+const PREDEFINED_NETWORKS = ['host', 'bridge', 'none'];
 
+class NetworkHelper {
   isSystemNetwork(item) {
-    return _.includes(this.PREDEFINED_NETWORKS, item.Name);
+    return _.includes(PREDEFINED_NETWORKS, item.Name);
   }
 }
 

app/portainer/helpers/webhookHelper.js

@@ -1,7 +1,10 @@
+import angular from 'angular';
+
+import { API_ENDPOINT_WEBHOOKS } from '@/constants';
+
 angular.module('portainer.app').factory('WebhookHelper', [
   '$location',
-  'API_ENDPOINT_WEBHOOKS',
-  function WebhookHelperFactory($location, API_ENDPOINT_WEBHOOKS) {
+  function WebhookHelperFactory($location) {
     'use strict';
     var helper = {};
 
@@ -10,7 +13,8 @@ angular.module('portainer.app').factory('WebhookHelper', [
         ($location.protocol().toLowerCase() === 'http' && $location.port() === 80) || ($location.protocol().toLowerCase() === 'https' && $location.port() === 443)
           ? ''
           : ':' + $location.port();
-      return $location.protocol() + '://' + $location.host() + displayPort + '/' + API_ENDPOINT_WEBHOOKS + '/' + token;
+
+      return `${$location.protocol()}://${$location.host()}${displayPort}/${API_ENDPOINT_WEBHOOKS}/${token}`;
     };
 
     return helper;

app/portainer/rest/auth.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_AUTH = 'api/auth';
+
 angular.module('portainer.app').factory('Auth', [
   '$resource',
-  'API_ENDPOINT_AUTH',
-  function AuthFactory($resource, API_ENDPOINT_AUTH) {
+  function AuthFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_AUTH + '/:action',

app/portainer/rest/backup.js

@@ -1,10 +1,11 @@
+const API_ENDPOINT_BACKUP = 'api/backup';
+
 angular.module('portainer.app').factory('Backup', [
   '$resource',
-  'API_ENDPOINT_BACKUP',
-  function BackupFactory($resource, API_ENDPOINT_BACKUP) {
+  function BackupFactory($resource) {
     'use strict';
     return $resource(
-      API_ENDPOINT_BACKUP + '/:subResource/:action',
+      `${API_ENDPOINT_BACKUP}/:subResource/:action`,
       {},
       {
         download: {

app/portainer/rest/customTemplate.js

@@ -1,8 +1,10 @@
 import angular from 'angular';
 
+export const API_ENDPOINT_CUSTOM_TEMPLATES = 'api/custom_templates';
+
 angular.module('portainer.app').factory('CustomTemplates', CustomTemplatesFactory);
 
-function CustomTemplatesFactory($resource, API_ENDPOINT_CUSTOM_TEMPLATES) {
+function CustomTemplatesFactory($resource) {
   return $resource(
     API_ENDPOINT_CUSTOM_TEMPLATES + '/:id/:action',
     {},

app/portainer/rest/dockerhub.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_DOCKERHUB = 'api/dockerhub';
+
 angular.module('portainer.app').factory('DockerHub', [
   '$resource',
-  'API_ENDPOINT_DOCKERHUB',
-  function DockerHubFactory($resource, API_ENDPOINT_DOCKERHUB) {
+  function DockerHubFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_DOCKERHUB,

app/portainer/rest/gitlab.js

@@ -1,9 +1,12 @@
+import angular from 'angular';
+
+import { API_ENDPOINT_REGISTRIES } from '@/constants';
+
 import gitlabResponseGetLink from './transform/gitlabResponseGetLink';
 
 angular.module('portainer.app').factory('Gitlab', [
   '$resource',
-  'API_ENDPOINT_REGISTRIES',
-  function GitlabFactory($resource, API_ENDPOINT_REGISTRIES) {
+  function GitlabFactory($resource) {
     'use strict';
     return function (env) {
       const headers = {};
@@ -12,7 +15,7 @@ angular.module('portainer.app').factory('Gitlab', [
         headers['X-Gitlab-Domain'] = env.url;
       }
 
-      const baseUrl = API_ENDPOINT_REGISTRIES + '/:id/proxies/gitlab/api/v4/projects';
+      const baseUrl = `${API_ENDPOINT_REGISTRIES}/:id/proxies/gitlab/api/v4/projects`;
 
       return $resource(
         baseUrl,

app/portainer/rest/group.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_ENDPOINT_GROUPS = 'api/endpoint_groups';
+
 angular.module('portainer.app').factory('EndpointGroups', [
   '$resource',
-  'API_ENDPOINT_ENDPOINT_GROUPS',
-  function EndpointGroupsFactory($resource, API_ENDPOINT_ENDPOINT_GROUPS) {
+  function EndpointGroupsFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_ENDPOINT_GROUPS + '/:id/:action',

app/portainer/rest/motd.js

@@ -1,7 +1,8 @@
+export const API_ENDPOINT_MOTD = 'api/motd';
+
 angular.module('portainer.app').factory('Motd', [
   '$resource',
-  'API_ENDPOINT_MOTD',
-  function MotdFactory($resource, API_ENDPOINT_MOTD) {
+  function MotdFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_MOTD,

app/portainer/rest/registry.js

@@ -1,10 +1,12 @@
+import angular from 'angular';
+
+import { API_ENDPOINT_REGISTRIES } from '@/constants';
+
 angular.module('portainer.app').factory('Registries', [
   '$resource',
-  'API_ENDPOINT_REGISTRIES',
-  function RegistriesFactory($resource, API_ENDPOINT_REGISTRIES) {
-    'use strict';
+  function RegistriesFactory($resource) {
     return $resource(
-      API_ENDPOINT_REGISTRIES + '/:id/:action',
+      `${API_ENDPOINT_REGISTRIES}/:id/:action`,
       {},
       {
         create: { method: 'POST', ignoreLoadingBar: true },

app/portainer/rest/resourceControl.js

@@ -1,7 +1,8 @@
+export const API_ENDPOINT_RESOURCE_CONTROLS = 'api/resource_controls';
+
 angular.module('portainer.app').factory('ResourceControl', [
   '$resource',
-  'API_ENDPOINT_RESOURCE_CONTROLS',
-  function ResourceControlFactory($resource, API_ENDPOINT_RESOURCE_CONTROLS) {
+  function ResourceControlFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_RESOURCE_CONTROLS + '/:id',

app/portainer/rest/settings.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_SETTINGS = 'api/settings';
+
 angular.module('portainer.app').factory('Settings', [
   '$resource',
-  'API_ENDPOINT_SETTINGS',
-  function SettingsFactory($resource, API_ENDPOINT_SETTINGS) {
+  function SettingsFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_SETTINGS + '/:subResource/:action',

app/portainer/rest/stack.js

@@ -1,8 +1,8 @@
+const API_ENDPOINT_STACKS = 'api/stacks';
+
 angular.module('portainer.app').factory('Stack', [
   '$resource',
-  'EndpointProvider',
-  'API_ENDPOINT_STACKS',
-  function StackFactory($resource, EndpointProvider, API_ENDPOINT_STACKS) {
+  function StackFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_STACKS + '/:id/:action',

app/portainer/rest/status.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_STATUS = 'api/status';
+
 angular.module('portainer.app').factory('Status', [
   '$resource',
-  'API_ENDPOINT_STATUS',
-  function StatusFactory($resource, API_ENDPOINT_STATUS) {
+  function StatusFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_STATUS + '/:action',

app/portainer/rest/support.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_SUPPORT = 'api/support';
+
 angular.module('portainer.app').factory('Support', [
   '$resource',
-  'API_ENDPOINT_SUPPORT',
-  function SupportFactory($resource, API_ENDPOINT_SUPPORT) {
+  function SupportFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_SUPPORT,

app/portainer/rest/tag.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_TAGS = 'api/tags';
+
 angular.module('portainer.app').factory('Tags', [
   '$resource',
-  'API_ENDPOINT_TAGS',
-  function TagsFactory($resource, API_ENDPOINT_TAGS) {
+  function TagsFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_TAGS + '/:id',

app/portainer/rest/team.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_TEAMS = 'api/teams';
+
 angular.module('portainer.app').factory('Teams', [
   '$resource',
-  'API_ENDPOINT_TEAMS',
-  function TeamsFactory($resource, API_ENDPOINT_TEAMS) {
+  function TeamsFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_TEAMS + '/:id/:entity/:entityId',

app/portainer/rest/teamMembership.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_TEAM_MEMBERSHIPS = 'api/team_memberships';
+
 angular.module('portainer.app').factory('TeamMemberships', [
   '$resource',
-  'API_ENDPOINT_TEAM_MEMBERSHIPS',
-  function TeamMembershipsFactory($resource, API_ENDPOINT_TEAM_MEMBERSHIPS) {
+  function TeamMembershipsFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_TEAM_MEMBERSHIPS + '/:id/:action',

app/portainer/rest/template.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_TEMPLATES = 'api/templates';
+
 angular.module('portainer.app').factory('Templates', [
   '$resource',
-  'API_ENDPOINT_TEMPLATES',
-  function TemplatesFactory($resource, API_ENDPOINT_TEMPLATES) {
+  function TemplatesFactory($resource) {
     return $resource(
       API_ENDPOINT_TEMPLATES + '/:action',
       {},

app/portainer/rest/user.js

@@ -1,7 +1,8 @@
+const API_ENDPOINT_USERS = 'api/users';
+
 angular.module('portainer.app').factory('Users', [
   '$resource',
-  'API_ENDPOINT_USERS',
-  function UsersFactory($resource, API_ENDPOINT_USERS) {
+  function UsersFactory($resource) {
     'use strict';
     return $resource(
       API_ENDPOINT_USERS + '/:id/:entity/:entityId',

app/portainer/rest/webhooks.js

@@ -1,10 +1,12 @@
+import angular from 'angular';
+
+import { API_ENDPOINT_WEBHOOKS } from '@/constants';
+
 angular.module('portainer.app').factory('Webhooks', [
   '$resource',
-  'API_ENDPOINT_WEBHOOKS',
-  function WebhooksFactory($resource, API_ENDPOINT_WEBHOOKS) {
-    'use strict';
+  function WebhooksFactory($resource) {
     return $resource(
-      API_ENDPOINT_WEBHOOKS + '/:id',
+      `${API_ENDPOINT_WEBHOOKS}/:id`,
       {},
       {
         query: { method: 'GET', isArray: true },

app/portainer/services/pagination.js

@@ -1,7 +1,10 @@
+import angular from 'angular';
+
+import { PAGINATION_MAX_ITEMS } from '@/constants';
+
 angular.module('portainer.app').factory('PaginationService', [
   'LocalStorage',
-  'PAGINATION_MAX_ITEMS',
-  function PaginationServiceFactory(LocalStorage, PAGINATION_MAX_ITEMS) {
+  function PaginationServiceFactory(LocalStorage) {
     'use strict';
 
     var service = {};

app/portainer/services/stateManager.js

@@ -1,5 +1,7 @@
 import moment from 'moment';
 
+const APPLICATION_CACHE_VALIDITY = 3600;
+
 angular.module('portainer.app').factory('StateManager', [
   '$q',
   'SystemService',
@@ -8,21 +10,9 @@ angular.module('portainer.app').factory('StateManager', [
   'LocalStorage',
   'SettingsService',
   'StatusService',
-  'APPLICATION_CACHE_VALIDITY',
   'AgentPingService',
   '$analytics',
-  function StateManagerFactory(
-    $q,
-    SystemService,
-    InfoHelper,
-    EndpointProvider,
-    LocalStorage,
-    SettingsService,
-    StatusService,
-    APPLICATION_CACHE_VALIDITY,
-    AgentPingService,
-    $analytics
-  ) {
+  function StateManagerFactory($q, SystemService, InfoHelper, EndpointProvider, LocalStorage, SettingsService, StatusService, AgentPingService, $analytics) {
     'use strict';
 
     var manager = {};