Compare commits
3 Commits
feat/EE-35
...
fix/ce-51-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f47737afe9 | ||
|
|
bc31a8dbb3 | ||
|
|
ba23d2f978 |
@@ -1,7 +1,9 @@
|
||||
package team
|
||||
|
||||
import (
|
||||
"github.com/portainer/portainer/api"
|
||||
"strings"
|
||||
|
||||
portainer "github.com/portainer/portainer/api"
|
||||
"github.com/portainer/portainer/api/bolt/errors"
|
||||
"github.com/portainer/portainer/api/bolt/internal"
|
||||
|
||||
@@ -58,7 +60,7 @@ func (service *Service) TeamByName(name string) (*portainer.Team, error) {
|
||||
return err
|
||||
}
|
||||
|
||||
if t.Name == name {
|
||||
if strings.EqualFold(t.Name, name) {
|
||||
team = &t
|
||||
break
|
||||
}
|
||||
|
||||
@@ -1,10 +1,11 @@
|
||||
package user
|
||||
|
||||
import (
|
||||
"github.com/portainer/portainer/api"
|
||||
"strings"
|
||||
|
||||
portainer "github.com/portainer/portainer/api"
|
||||
"github.com/portainer/portainer/api/bolt/errors"
|
||||
"github.com/portainer/portainer/api/bolt/internal"
|
||||
"strings"
|
||||
|
||||
"github.com/boltdb/bolt"
|
||||
)
|
||||
@@ -61,7 +62,7 @@ func (service *Service) UserByUsername(username string) (*portainer.User, error)
|
||||
return err
|
||||
}
|
||||
|
||||
if strings.ToLower(u.Username) == username {
|
||||
if strings.EqualFold(u.Username, username) {
|
||||
user = &u
|
||||
break
|
||||
}
|
||||
|
||||
@@ -28,7 +28,7 @@ require (
|
||||
github.com/portainer/libcompose v0.5.3
|
||||
github.com/portainer/libcrypto v0.0.0-20190723020515-23ebe86ab2c2
|
||||
github.com/portainer/libhttp v0.0.0-20190806161843-ba068f58be33
|
||||
github.com/stretchr/testify v1.6.1 // indirect
|
||||
github.com/stretchr/testify v1.6.1
|
||||
golang.org/x/crypto v0.0.0-20191128160524-b544559bb6d1
|
||||
golang.org/x/net v0.0.0-20191126235420-ef20fe5d7933 // indirect
|
||||
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45
|
||||
|
||||
@@ -8,7 +8,7 @@ import (
|
||||
"github.com/portainer/portainer/api/http/proxy/factory/responseutils"
|
||||
"github.com/portainer/portainer/api/internal/authorization"
|
||||
|
||||
"github.com/portainer/portainer/api"
|
||||
portainer "github.com/portainer/portainer/api"
|
||||
)
|
||||
|
||||
const (
|
||||
@@ -29,6 +29,23 @@ type (
|
||||
}
|
||||
)
|
||||
|
||||
func getUniqueElements(items string) []string {
|
||||
result := []string{}
|
||||
seen := make(map[string]struct{})
|
||||
for _, item := range strings.Split(items, ",") {
|
||||
v := strings.TrimSpace(item)
|
||||
if v == "" {
|
||||
continue
|
||||
}
|
||||
if _, ok := seen[v]; !ok {
|
||||
result = append(result, v)
|
||||
seen[v] = struct{}{}
|
||||
}
|
||||
}
|
||||
|
||||
return result
|
||||
}
|
||||
|
||||
func (transport *Transport) newResourceControlFromPortainerLabels(labelsObject map[string]interface{}, resourceID string, resourceType portainer.ResourceControlType) (*portainer.ResourceControl, error) {
|
||||
if labelsObject[resourceLabelForPortainerPublicResourceControl] != nil {
|
||||
resourceControl := authorization.NewPublicResourceControl(resourceID, resourceType)
|
||||
@@ -45,12 +62,12 @@ func (transport *Transport) newResourceControlFromPortainerLabels(labelsObject m
|
||||
userNames := make([]string, 0)
|
||||
if labelsObject[resourceLabelForPortainerTeamResourceControl] != nil {
|
||||
concatenatedTeamNames := labelsObject[resourceLabelForPortainerTeamResourceControl].(string)
|
||||
teamNames = strings.Split(concatenatedTeamNames, ",")
|
||||
teamNames = getUniqueElements(concatenatedTeamNames)
|
||||
}
|
||||
|
||||
if labelsObject[resourceLabelForPortainerUserResourceControl] != nil {
|
||||
concatenatedUserNames := labelsObject[resourceLabelForPortainerUserResourceControl].(string)
|
||||
userNames = strings.Split(concatenatedUserNames, ",")
|
||||
userNames = getUniqueElements(concatenatedUserNames)
|
||||
}
|
||||
|
||||
if len(teamNames) > 0 || len(userNames) > 0 {
|
||||
|
||||
63
api/http/proxy/factory/docker/access_control_test.go
Normal file
63
api/http/proxy/factory/docker/access_control_test.go
Normal file
@@ -0,0 +1,63 @@
|
||||
package docker
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
func Test_getUniqueElements(t *testing.T) {
|
||||
cases := []struct {
|
||||
description string
|
||||
input string
|
||||
expected []string
|
||||
}{
|
||||
{
|
||||
description: "no items padded",
|
||||
input: " ",
|
||||
expected: []string{},
|
||||
},
|
||||
{
|
||||
description: "single item",
|
||||
input: "a",
|
||||
expected: []string{"a"},
|
||||
},
|
||||
{
|
||||
description: "single item padded",
|
||||
input: " a ",
|
||||
expected: []string{"a"},
|
||||
},
|
||||
{
|
||||
description: "multiple items",
|
||||
input: "a,b",
|
||||
expected: []string{"a", "b"},
|
||||
},
|
||||
{
|
||||
description: "multiple items padded",
|
||||
input: " a , b ",
|
||||
expected: []string{"a", "b"},
|
||||
},
|
||||
{
|
||||
description: "multiple items with empty values",
|
||||
input: " a , ,b ",
|
||||
expected: []string{"a", "b"},
|
||||
},
|
||||
{
|
||||
description: "duplicates",
|
||||
input: " a , a ",
|
||||
expected: []string{"a"},
|
||||
},
|
||||
{
|
||||
description: "mix with duplicates",
|
||||
input: " a ,b, a ",
|
||||
expected: []string{"a", "b"},
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range cases {
|
||||
t.Run(tt.description, func(t *testing.T) {
|
||||
result := getUniqueElements(tt.input)
|
||||
assert.ElementsMatch(t, result, tt.expected)
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user