From f8b9d2501c2b13730bd457465b200a47648faa30 Mon Sep 17 00:00:00 2001
From: Oscar Zhou <oscar.zhou@portainer.io>
Date: Thu, 22 Dec 2022 08:28:40 +1300
Subject: [PATCH] chore: convert the specific error message to constant string
 type

---
 api/internal/upgrade/upgrade.go | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/api/internal/upgrade/upgrade.go b/api/internal/upgrade/upgrade.go
index 9cdfea4d0..31422400c 100644
--- a/api/internal/upgrade/upgrade.go
+++ b/api/internal/upgrade/upgrade.go
@@ -29,12 +29,9 @@ const (
 	skipPullImageEnvVar = "UPGRADE_SKIP_PULL_PORTAINER_IMAGE"
 	// updaterImageEnvVar represents the name of the environment variable used to define the updater image
 	// useful if there's a need to test a different updater
-	updaterImageEnvVar = "UPGRADE_UPDATER_IMAGE"
-)
-
-var (
-	errUpdateFailure    = errors.New("update failure")
-	errPullImageFailure = errors.New("pull image failure")
+	updaterImageEnvVar         = "UPGRADE_UPDATER_IMAGE"
+	errMessageUpdateFailure    = "update failure"
+	errMessagePullImageFailure = "pull image failure"
 )
 
 type Service interface {
@@ -131,8 +128,8 @@ func (service *service) upgradeDocker(licenseKey, version, envType string) error
 			Options: libstack.Options{
 				ProjectName: projectName,
 				PotentialErrors: []string{
-					errUpdateFailure.Error(),
-					errPullImageFailure.Error(),
+					errMessageUpdateFailure,
+					errMessagePullImageFailure,
 				},
 			},
 		},