From dceeb3a7572f0ddd6b394c658a022f960a95976f Mon Sep 17 00:00:00 2001
From: Felix Han <felix.han@portainer.io>
Date: Tue, 16 Mar 2021 09:24:22 +1300
Subject: [PATCH] fix(app): CE-478 removed comments

---
 .../views/configure/configureController.js    |  8 --------
 app/portainer/services/endpointProvider.js    | 20 -------------------
 2 files changed, 28 deletions(-)

diff --git a/app/kubernetes/views/configure/configureController.js b/app/kubernetes/views/configure/configureController.js
index a66bf5a19..0e1887836 100644
--- a/app/kubernetes/views/configure/configureController.js
+++ b/app/kubernetes/views/configure/configureController.js
@@ -8,14 +8,6 @@ import { KubernetesIngressClassTypes } from 'Kubernetes/ingress/constants';
 
 class KubernetesConfigureController {
   /* #region  CONSTRUCTOR */
-
-  // TODO: technical debt
-  // $transition$ cannot be injected as bindings: { $transition$: '<' } inside app/portainer/__module.js
-  // because this view is not using a component (https://ui-router.github.io/guide/ng1/route-to-component#accessing-transition)
-  // and will cause
-  // >> Error: Cannot combine: component|bindings|componentProvider
-  // >> with: templateProvider|templateUrl|template|notify|async|controller|controllerProvider|controllerAs|resolveAs
-  // >> in stateview: 'content@@portainer.endpoints.endpoint.kubernetesConfig'
   /* @ngInject */
   constructor(
     $async,
diff --git a/app/portainer/services/endpointProvider.js b/app/portainer/services/endpointProvider.js
index ea18ca01d..b8c85b72f 100644
--- a/app/portainer/services/endpointProvider.js
+++ b/app/portainer/services/endpointProvider.js
@@ -43,26 +43,6 @@ angular.module('portainer.app').factory(
       return endpoint.ID;
     };
 
-    // TODO: technical debt
-    // Reference issue: JIRA CE-463
-    // Documentation (https://ui-router.github.io/ng1/docs/latest/modules/injectables.html) show the usage of either
-    // * $stateParams
-    // * $transition$
-    // * $uiRouterGlobals
-    // to retrieve the URL params
-    //
-    // * $stateParams: is deprecated and will cause a circular dependency injection error
-    // because EndpointProvider is used by EndpointStatusInterceptor which is injected inside $httpProvider
-    // >> [$injector:cdep] Circular dependency found: $uiRouter <- $stateParams <- EndpointProvider <- EndpointStatusInterceptor <- $http <- $uiRouter
-    // For more details, see https://stackoverflow.com/questions/20230691/injecting-state-ui-router-into-http-interceptor-causes-circular-dependency#20230786
-    //
-    // * $transition$: mentionned as the replacement of $stateParams (https://ui-router.github.io/guide/ng1/migrate-to-1_0#stateparams-deprecation)
-    // but is not injectable without tweaks inside a service
-    //
-    // * $uiRouterGlobal: per https://github.com/angular-ui/ui-router/issues/3237#issuecomment-271979688
-    // seems the recommanded way to retrieve params inside a service/factory
-    //
-    // We need this function to fallback on URL endpoint ID when no endpoint has been selected
     service.getUrlEndpointID = () => {
       return $uiRouterGlobals.params.id;
     };