From 3f7a3053ff19377545497c58a8b64066c3b52fe2 Mon Sep 17 00:00:00 2001 From: Oscar Zhou <100548325+oscarzhou-portainer@users.noreply.github.com> Date: Tue, 24 Feb 2026 08:41:42 +1300 Subject: [PATCH] fix(stack): avoid removing running service if stack deployment fails [BE-12542] (#1940) --- api/stacks/deployments/deployer.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/api/stacks/deployments/deployer.go b/api/stacks/deployments/deployer.go index 3f5277ffd..862ee9526 100644 --- a/api/stacks/deployments/deployer.go +++ b/api/stacks/deployments/deployer.go @@ -74,18 +74,10 @@ func (d *stackDeployer) DeployComposeStack(stack *portainer.Stack, endpoint *por } } - if err := d.composeStackManager.Up(context.TODO(), stack, endpoint, portainer.ComposeUpOptions{ + return d.composeStackManager.Up(context.TODO(), stack, endpoint, portainer.ComposeUpOptions{ ComposeOptions: options, ForceRecreate: forceRecreate, - }); err != nil { - if err := d.composeStackManager.Down(context.TODO(), stack, endpoint); err != nil { - log.Warn().Err(err).Msg("failed to cleanup compose stack after failed deployment") - } - - return err - } - - return nil + }) } func (d *stackDeployer) DeployKubernetesStack(stack *portainer.Stack, endpoint *portainer.Endpoint, user *portainer.User) error {