blackroad-os/backroad
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(errors): wrap db errors, improve error handling (#8859)

Browse Source 
* use error check func, wrap db object not found

* add errorlint and fix all the linting errors

* add exportloopref linter and fix errors

* fix incorrect error details returned on an api

* fix new errors

* increase linter timeout

* increase timeout to 10minutes

* increase timeout to 10minutes

* rebase and fix new lint errors

* make CE match EE

* fix govet issue
This commit is contained in:
Matt Hook
2023-05-05 12:19:47 +12:00
committed by GitHub
parent 550e235d59
commit 334eee0c8c
52 changed files with 158 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
api/internal/edge/edgestack.go
View File

@@ -18,6 +18,7 @@ func EdgeStackRelatedEndpoints(edgeGroupIDs []portainer.EdgeGroupID, endpoints [
var edgeGroup *portainer.EdgeGroup
for _, group := range edgeGroups {
group := group
if group.ID == edgeGroupID {
edgeGroup = &group
break

2
api/internal/edge/edgestacks/service.go
View File

@@ -81,7 +81,7 @@ func (service *Service) PersistEdgeStack(
relatedEndpointIds, err := edge.EdgeStackRelatedEndpoints(stack.EdgeGroups, relationConfig.Endpoints, relationConfig.EndpointGroups, relationConfig.EdgeGroups)
if err != nil {
if err == edge.ErrEdgeGroupNotFound {
if errors.Is(err, edge.ErrEdgeGroupNotFound) {
return nil, httperrors.NewInvalidPayloadError(err.Error())
}
return nil, fmt.Errorf("unable to persist environment relation in database: %w", err)